[VALIDATED] [REFACTOR] Standardize LLM Provider Configurations#14
Merged
[VALIDATED] [REFACTOR] Standardize LLM Provider Configurations#14
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @HOLYKEYZ! Joseph, I've found an improvement for you.
Problem / Gap
The current configuration in
backend/app/core/config.pycontains duplicatedCOUNCIL_ENABLE_PARALLELsettings and ambiguous entries forGEMINI2_API_KEY,GEMINI2_MODEL,GEMINI2_TIMEOUT,GROK2_API_KEY,GROK2_MODEL, andGROK2_TIMEOUT. The README mentions 'Gemini 2' as a model, which is already covered byGEMINI_MODEL: 'gemini-2.5-flash', making theGEMINI2entries redundant as separate provider configurations. Similarly, theGROQ_API_KEYis aliased withGROK_API_KEY, but then separateGROK2entries exist, creating confusion about whether 'Grok' is a distinct provider or a misnomer for 'Groq'. The corresponding 'Grok' entry inextension/manifest.jsonshould also be removed if 'Grok' is not a distinct, supported platform.Solution & Insight
To address the inconsistency and redundancy in LLM provider configurations, we will remove the redundant
COUNCIL_ENABLE_PARALLELsetting and the ambiguousGEMINI2andGROK2entries frombackend/app/core/config.py. We will also remove the 'Grok' host permission fromextension/manifest.json.Impact
This change improves code clarity, reduces potential for misconfiguration, and ensures consistency with the documented LLM Council members.
Validated by Triple-AI: Scanner (Gemini 2.5 Flash) → Executor (Llama 3.3 70B) → Reviewer (Gemini 2.5 Flash)
Generated autonomously by Mayo 🤖